feat: storyboard UX, inline agent connect, OAuth auth#1998
Open
feat: storyboard UX, inline agent connect, OAuth auth#1998
Conversation
Short-circuit comply() when product discovery fails — skip dependent tracks instead of repeating the same error across 10+ scenarios. Saves significant time for agents with broken product schemas. Add inline agent connection form to dashboard — replaces the chat bounce for saving auth tokens and platform type. New PUT /registry/agents/:url/connect endpoint handles token storage directly. Filter storyboard picker by agent capabilities — groups into Recommended and Other based on the agent's compliance tracks. Signal storyboards show for signal agents, creative for creative agents, etc. Add creative_generative.yaml storyboard — covers the brief-driven generation flow (OpenAds, generative DSPs) with 5 phases: format discovery, generate from brief, refine, multi-format, production build. Fix resolveOwnerAuth() to fall back to OAuth tokens when no static bearer token exists, with 5-minute expiration buffer. Auto-scroll storyboard results into view after rendering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
- Add max-length validation (4096) on auth_token input - Validate auth_type against allowed values instead of silent fallback - Validate platform_type is a string before set membership check - Combine ownership verification and org lookup into single query - Log warning when OAuth token has no expiration recorded - Preserve agentTracks context through storyboard back button navigation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bokelley
commented
Apr 8, 2026
Contributor
Author
bokelley
left a comment
bokelley
left a comment
There was a problem hiding this comment.
Nice work — the two-phase comply() short-circuit is a good optimization, and the inline agent connect + storyboard picker are solid UX improvements.
Merge order with #1985: We're merging #1985 first (storyboard coverage + comply() migration). The main conflict will be in comply() in compliance-testing.ts. Here's how they compose:
#1985 adds a priority chain at the top of comply():
storyboards > scenarios > tracks > default
When storyboards or scenarios are provided, they bypass track-based selection entirely. Your two-phase logic applies to the track-based path (the else branch — when no storyboards or explicit scenarios are given).
When you rebase after #1985 merges, the reconciliation is:
- Keep the priority chain from #1985 (storyboards → scenarios → tracks)
- Apply your two-phase logic inside the track-based branch
- The
scenarioListvariable from #1985 feeds into your phase 1/phase 2 split
The storyboard path doesn't need two-phase execution because storyboards already select only relevant scenarios — if a storyboard doesn't reference full_sales_flow, products aren't tested.
Other notes:
creative_generative.yamlfills the gap we noticed — the category existed in schema.yaml but had no storyboard- #1985 adds
creative_generativeto the schema.yaml category enum already, so that should merge cleanly - The
SCENARIO_REQUIREMENTSimport you add is already available in #1985's version of the file
Integrates scenario filtering from #1985 with two-phase comply(): - Phase 1 filters scenarios to foundation tracks only - Phase 2 filters to remaining tracks - Both respect the storyboard-specific scenario list when provided Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
| } | ||
|
|
||
| // Replace the form with a success message and reload after a moment | ||
| const card = form.closest('.agent-compliance-card'); |
The two-phase approach (run core+products first, then skip dependent tracks) is no longer needed: #1985's scenario filtering already limits comply() to only the scenarios a storyboard references, and @adcp/client's storyboard runner will handle step-by-step short-circuiting. Remove isTrackProductDependent(), foundation/remaining track splitting, and the product-availability check. comply() now runs all requested scenarios in a single testAllScenarios() call. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alignment with #1985
These changes are compatible with #1985 (storyboard coverage and comply() scenario filtering). The overlap is in
compliance-testing.ts— #1985 addsextractScenariosFromStoryboard()and scenario filtering in the run endpoint, while this PR adds two-phase comply() execution. They compose cleanly: filtered scenarios still flow through the two-phase comply(). Merge order doesn't matter; the second to merge will need a small conflict resolution incompliance-testing.ts.Changes
comply() short-circuit (
compliance-testing.ts)Inline agent connect (
registry-api.ts+dashboard-agents.html)PUT /registry/agents/:encodedUrl/connect— saves auth token + platform typeStoryboard picker filtering (
dashboard-agents.html)Generative creative storyboard (
creative_generative.yaml)OAuth in resolveOwnerAuth() (
compliance-db.ts)Test plan
🤖 Generated with Claude Code